Merged
Conversation
* All element on the error panel are now hidden by default (expect for the ``errorTextView``) as they are only optional shown * Added a method to ensure the above * This deduplicates a lot of code * Fixed format of some LoC * Added new method: ``showAndSetErrorButtonAction`` * Fixed ``showTextError`` * Named buttons more logically: ``errorButtonAction`` -> ``errorActionButton``
litetex
added
bug
Stypox
approved these changes
Aug 31, 2021
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Thank you! I can confirm it works. I don't know why I went with that strange design of setting things only if needed (and thus obviously forgetting something), this looks much better
This was referenced Sep 4, 2021
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
I tried to fix #7003 quickly as mentioned in #7003 (comment) however I found some major issues with the ErrorPanel that made it very poor understandable, caused #7003 in the first place and decided to fix these instead.
Summary of changes:
errorTextView) as they are only optional shown - depending on the situation and type of the errorshowAndSetErrorButtonAction(see JavaDoc for more information)errorButtonAction->errorActionButtonBefore/After Screenshots/Screen Record
- After:Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence